SEPURI-SAI-KRISHNA commented on issue #44314: URL: https://github.com/apache/superset/issues/44314#issuecomment-5689999063
Thanks for looking into this. I can't reproduce those failures, and I think this file is a false lead. Checking on master itself rather than a branch: the last master run that actually executed Jest before your commit is [`dbccb3bc`](https://github.com/apache/superset/actions/runs/34999633998), and shard 4 of that run shows this file passing: ``` PASS src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx (37.884 s) Test Suites: 1 skipped, 162 passed, 162 of 163 total Tests: 14 skipped, 1638 passed, 1652 total ``` `a184395e` is a docs-only `oxfmt` bump, and no `superset-frontend/` file changed between `dbccb3bc`, `a184395e` and current master `b1380cf4`. The frontend tree at the commit you tested is therefore byte-identical to the one CI shows green, so there is no window for 12 deterministic failures to have been introduced. That matches locally: 46/46 pass for me on Node 24.16.0 across three runs (twice plain, once with `--coverage`), with the test file, `index.tsx`, `useAdvancedDataTypes.ts`, `package.json`, `jest.config.js` and `spec/helpers/testing-library.tsx` all byte-identical to master. Worth noting that `a184395e`'s own `sharded-jest-tests` job was **skipped** by the workflow's path filters, since the commit only touches `/docs` — so that run never exercised the frontend suite. Locally, skipping `npm run plugins:build` after `npm ci` will also fail a cluster of tests in a way that looks deterministic rather than flaky. On the proposed cause: all 24 `userEvent` calls in this file are already awaited. #43512 is in fact the file's most recent commit, so the v14 pass landed here fully. Both `document.querySelector('.ant-select-dropdown-list')` uses are awaited as well — one wrapped in `waitFor`, the other following an `await userEvent.type` — so the portal-timing symptom doesn't apply either. If you're still seeing it, could you post the full Jest output and your Node version? Absent a reproducible failure I'd rather keep this issue scoped to the single `ControlPanelsContainer` line it was opened for, and #44315 fixes that one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
