aminghadersohi commented on PR #44284: URL: https://github.com/apache/superset/pull/44284#issuecomment-5685572607
Ownership update: rechecked every current check and all reviews. There are no review threads (resolved or unresolved), and @rusackas remains requested. All 15 red checks were inspected: 12 execution jobs fail on the shared multiple-Alembic-head startup error, plus three dependent required gates. No required check is skipped; the skipped frontend/release/bot jobs are conditionally inapplicable. This remains blocked, not acceptable CI. I have coordinated #44288 / #44317 / #44283 to avoid landing duplicate merge heads, and will rebase onto the chosen upstream repair once it lands, then rerun CI here.\n\nRegarding the bot suggestion: the before/after compile assertion intentionally guards against WhereInMacro mutating the shared dialect; deterministic compilation alone does not make that assertion tautological because the macro is called between the two compilations. I have strengthened the test locally with an explicit expected compiler-escaped literal and an explanatory comment. The full Jinja module passes (202 tests), and changed-file pre-commit including mypy/ruff/pylint passes. I am holding the push for the baseline rebase to avoid a predictably blocked duplicate CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
