aminghadersohi commented on PR #44284:
URL: https://github.com/apache/superset/pull/44284#issuecomment-5689715580
### CI is now fully green on `6329ca06d2c456c751488dfb85a9656c0622c943`
The master blocker cleared: **#44288 merged upstream at
2026-09-15T20:50:43Z** (`4c27cbd007efa298c2c1101b85a1ea158ed0502a`). Master now
has a **single** Alembic head, `e2f3a1b9c640` (388 revisions, verified by
AST-parsing every file under `superset/migrations/versions`).
I rebased this PR onto master `6cfb33197444cbf74590c2803b6dcc06180439f4` —
clean, no conflicts — and re-ran CI.
**Result: 64 pass, 12 skipped-as-inapplicable, 0 fail.**
`statusCheckRollup.state = SUCCESS` across 76 contexts.
Every job that was failing on the previous head now passes, with no change
on this branch other than the rebase:
| Previously failing | Now |
| --- | --- |
| `test-postgres (current)`, `test-mysql`, `test-sqlite`,
`test-load-examples` | pass |
| `test-postgres-hive`, `test-postgres-presto` | pass |
| `cypress-matrix (chrome)` | pass |
| `playwright-tests (chromium)`, `playwright-tests (chromium, /app/prefix)`
| pass |
| `playwright-tests-experimental (chromium)`, `playwright-tests-experimental
(chromium, /app/prefix)` | pass |
| `docker-build (dev)` | pass |
| `test-postgres-required`, `playwright-tests-required`,
`cypress-matrix-required` | pass |
Also green: `unit-tests (current)`, `unit-tests-required`, `pre-commit
(current)`, `lint-check`, `enforce-single-migration-head`, `codecov/patch`,
`codecov/project`, `Analyze (python)`, `Analyze (javascript)`, `docker-build
(superset)`, `docker-build (lean)`, `License Check`, `check-python-deps`,
`dependency-review`, `python-dependency-liccheck`, `check-openapi-spec-drift`.
I checked for hidden failures rather than trusting the checks summary alone.
Enumerating **all 24 workflow runs** at this SHA gives `success=21, skipped=3`
— no failed, cancelled, `action_required`, or zero-job run. The 3 skipped
workflows are Superset Showtime, Dependabot patch auto-approve, and the Python
dependency-requirements sync, none of which apply to a three-file Python/docs
PR. Check-run conclusions across every app are `success=63, skipped=10,
neutral=2`; the two neutral ones are Netlify informational ("No header rules
processed", "1898 new files uploaded"). Combined commit status is `success`.
The 12 skipped checks are the frontend path-filtered gates (`lint-frontend`,
`validate-frontend`, `sharded-jest-tests`, `test-storybook`, `bundle-size`,
`report-coverage`) plus bot/Netlify-informational jobs — this PR touches no
frontend files.
**No failures were waived and nothing was re-run to mask a result.**
### Unchanged since the last push
Diff is still exactly three files: `superset/jinja_context.py` (+5),
`tests/unit_tests/jinja_context_test.py`,
`docs/docs/using-superset/sql-templating.mdx`. `HEAD:superset/migrations`
equals `master:superset/migrations`
(`df1419fdb9ae79b3fa1f5973fe05fbea22b4338c`) — this PR adds no migration.
Locally on this head: `tests/unit_tests/jinja_context_test.py` = **202
passed**, with `test_where_in_athena_parameterless_execution` genuinely
executing (PyAthena 2.25.0 installed, not skipped). All changed-file pre-commit
hooks pass: mypy, ruff, ruff-format, pylint.
The one piece of review feedback — the bito suggestion about the
before/after recompile assertion — was addressed in the previous push and
carries forward: both compilations are pinned to an explicitly computed
compiler-escaped literal derived from the `paramstyle`, and the assertions are
mutation-tested (deleting the fix fails 35 cases; making the macro mutate the
shared dialect fails 18).
### Remaining gate
`mergeStateStatus` is `BLOCKED` solely because `reviewDecision` is
`REVIEW_REQUIRED`. There is no failing or missing check. **The only remaining
action is a committer's approving review** — @rusackas is requested. I am not
merging and not converting this to a draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
