hainenber commented on code in PR #44201:
URL: https://github.com/apache/superset/pull/44201#discussion_r4027188726
##########
superset-frontend/custom-lint-rules/theme-colors/index.js:
##########
@@ -85,11 +105,22 @@ const plugin: { rules: Record<string, Rule.RuleModule> } =
{
},
schema: [],
},
- create(context: Rule.RuleContext): Rule.RuleListener {
- const warned: string[] = [];
+ /**
+ * @param {import('oxlint').Rule.RuleContext} context
+ * @returns {import('oxlint').Rule.RuleListener}
+ */
+ createOnce(context) {
Review Comment:
Good callout, Joe. ~~This should belong to the `before` hook! I'll amend in
upcoming commit~~
On a 2nd thought, we probably stick to eslint-compat `create` semantics
instead for robustness and usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
