rusackas commented on PR #40679: URL: https://github.com/apache/superset/pull/40679#issuecomment-5700509563
Nothing for me to add here on the code review side. This is blocked on process, not quality: I kicked off the [VOTE][SIP-161] thread on dev@ myself on 2026-08-28, and it's still sitting at one binding +1 (Joe Li) plus two non-binding +1s, no [RESULT] yet. The hold:sip! label (added 2026-09-08) is correctly gated on that, not a mislabel. On the PR itself: all 26 review threads are resolved, no open conflicts, requires:rebase was cleared 2026-09-09. CI is effectively green - the only failures are check-hold-label (expected, that's what it's for) and one sharded-jest-tests shard failing on an unrelated ExploreChartHeader export-menu hover timeout, not touched by this diff. Nothing here needs a push or a nudge; it just needs the vote to land. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
