bito-code-review[bot] commented on code in PR #40679:
URL: https://github.com/apache/superset/pull/40679#discussion_r4036658798
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -109,6 +109,10 @@ export interface SliceHeaderControlsProps {
description: string;
viz_type: string;
slice_name: string;
+ // The name as rendered in the header: the localized value, or the panel's
+ // own title override. Used for strings the viewer reads; slice_name stays
+ // the canonical value for edits, filenames and extension payloads.
+ display_name?: string;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Interface copies diverged</b></div>
<div id="fix">
`display_name` was added to the `SliceHeaderControlsProps` interface here
(line 115), but the duplicate interface in `types.ts` (imported by
`SliceHeader/index.tsx` at line 53) was not updated. The two copies now
diverge: `SliceHeader`'s `slice` type lacks `display_name` even though
`Chart.tsx` passes it. Keep both copies in sync to avoid future drift.
</div>
</div>
<small><i>Code Review Run #fa16e0</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
