aminghadersohi commented on code in PR #44258:
URL: https://github.com/apache/superset/pull/44258#discussion_r4034973636
##########
superset/versioning/activity/queries.py:
##########
@@ -371,7 +374,11 @@ def _select_change_rows_for_kinds(
# declared on the Continuum Table by ``VersionTransactionFactory``,
# so ``tx_tbl.c.action_kind`` resolves cleanly here. See
# the three change-record dimensions.
- tx_tbl.c.action_kind,
+ # Internal provenance is not part of the public action vocabulary.
+ sa.case(
Review Comment:
Deleting this `sa.case` leaves all 213 versioning unit tests green; its only
pin is the new integration test, whose job dies at `db upgrade`. Without it a
mixed create+edit tx ships `action_kind:"create"`, outside this API's own enum
(clone/import/restore). No fence — the fix is a test elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
