mikebridge commented on code in PR #44258:
URL: https://github.com/apache/superset/pull/44258#discussion_r4039658600
##########
superset/versioning/activity/queries.py:
##########
@@ -371,7 +374,11 @@ def _select_change_rows_for_kinds(
# declared on the Continuum Table by ``VersionTransactionFactory``,
# so ``tx_tbl.c.action_kind`` resolves cleanly here. See
# the three change-record dimensions.
- tx_tbl.c.action_kind,
+ # Internal provenance is not part of the public action vocabulary.
+ sa.case(
Review Comment:
Good catch — addressed in 03479827513ca8e6b0d06b5b9d0deb1026913b6f with a
six-case unit regression that executes fetch_change_records against SQLite.
Removing the CASE produces exactly two failures (create/baseline); restoring it
passes all six, preserving clone/import/restore and NULL. The affected Python
suite passes 163 tests, and required hooks including MyPy pass. This head also
incorporates master with the merged migration repair (#44364); new-head CI
remains pending, so these are local results, not a claim that the database
matrix has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
