mikebridge commented on code in PR #44265:
URL: https://github.com/apache/superset/pull/44265#discussion_r4043534992
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -322,6 +333,39 @@ async def _run_get_table_query(
error_type="ValidationError",
)
+ required_dimensions: set[str] = (
+ set(request.dimensions)
+ | {
+ query_filter.col
+ for query_filter in request.filters
+ if not (
+ query_filter.op == "TEMPORAL_RANGE"
+ and query_filter.col in resolved.temporal_columns
Review Comment:
Addressed in 2daf0e449e571a59d0b0f96cc16cbd6fcbc7de80 — the exemption is
keyed on metadata-confirmed temporal columns across grouping, filters, and
ordering. Added accepted-axis/rejected-non-temporal regressions with discovery
omitting the column. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
