mikebridge commented on code in PR #44265:
URL: https://github.com/apache/superset/pull/44265#discussion_r4042114602
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -322,6 +326,30 @@ async def _run_get_table_query(
error_type="ValidationError",
)
+ required_dimensions: set[str] = set(request.dimensions) | {
+ query_filter.col for query_filter in request.filters
+ }
+ if (
+ not is_builtin
+ and resolved.view is not None
+ and request.metrics
+ and required_dimensions
+ ):
+ compatible: set[str] = set(
+ resolved.view.get_compatible_dimensions(request.metrics, [])
+ )
+ incompatible: list[str] = sorted(required_dimensions - compatible)
Review Comment:
Reproduced — an explicit TEMPORAL_RANGE on `order_ts` is rejected while
`time_column` + `time_range` (same builder output) passes. Decision: exempt
temporal-only filter columns from the compatibility guard so both spellings
work; that keeps parity with get_chart_data, which delegates to shared query
execution instead of this guard. Follow-up commit coming on this PR with a
regression test for both forms. The order_by fix in 0c5f7f2f is independent of
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
