bito-code-review[bot] commented on PR #44431:
URL: https://github.com/apache/superset/pull/44431#issuecomment-5738114151
<!-- Bito Reply -->
The flagged issue is correct. The current implementation of
`applyMappingMove` unconditionally resets `partition_transform_is_monotonic` to
`column.partition_transform_is_monotonic` (or `false` implicitly if not set)
whenever a new transform is applied, unless it is the identity transform. This
effectively discards a user's explicit monotonicity declaration even when the
new transform might still be monotonic.
To resolve this, you should update the logic in `applyMappingMove` to
preserve the existing `partition_transform_is_monotonic` value if the new
transform is also monotonic, or allow the user to retain their previous setting
unless they explicitly change it. A concise fix is to only reset the
monotonicity flag when the transform is explicitly changed to something that is
known to be non-monotonic, or simply preserve the existing value if the user
has already set it.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/src/components/Datasource/components/DatasourceEditor/components/PartitionFilterMapping/utils.ts**
```
partition_transform_is_monotonic:
nextValue === IDENTITY_TRANSFORM
? true
: column.partition_transform_is_monotonic,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
