codeant-ai-for-open-source[bot] commented on code in PR #44431:
URL: https://github.com/apache/superset/pull/44431#discussion_r4051754216
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/components/PartitionFilterMapping/PartitionMappingSection.tsx:
##########
@@ -178,7 +184,16 @@ export default function PartitionMappingSection({
</Flex>
<Input
value={transform}
- onChange={event => onChange?.(event.target.value || null)}
+ onChange={event => {
+ const next = event.target.value || null;
+ onChange?.(next);
+ // Monotonicity is a property of the expression, so editing the
+ // transform re-opens the question. The identity `:value` provably
+ // preserves ordering and stays auto-declared; anything else is the
+ // owner's to declare, and editing away from `:value` must not
leave
+ // a stale auto-check behind.
+ onMonotonicChange(columnName, next === IDENTITY_TRANSFORM);
Review Comment:
**Suggestion:** Editing any non-identity transform forces `isMonotonic` to
false, erasing a user's explicit monotonicity declaration even when it remains
valid.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0198f81b0c9144b092fc33627c672ce6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0198f81b0c9144b092fc33627c672ce6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/components/Datasource/components/DatasourceEditor/components/PartitionFilterMapping/PartitionMappingSection.tsx
**Line:** 195:195
**Comment:**
*Logic Error: Editing any non-identity transform forces `isMonotonic`
to false, erasing a user's explicit monotonicity declaration even when it
remains valid.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44431&comment_hash=147baa67120e24107aa9a931b258c50363322db3c1270d8ca4215456f8503ec3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44431&comment_hash=147baa67120e24107aa9a931b258c50363322db3c1270d8ca4215456f8503ec3&reaction=dislike'>๐</a>
##########
superset/db_engine_specs/base.py:
##########
@@ -722,6 +722,17 @@ def get_extended_aggregation_func(
# editor offers no pre-fill and the owner writes the transform themselves.
partition_value_transform_default: str | None = None
+ # Whether the dataset editor should offer partition filter mapping at all.
+ # This is a structural property of the engine, not a pre-fill: mapping a
+ # filter onto a physical partition column only prunes work on engines whose
+ # tables are laid out as partition directories (Hive-family). Elsewhere the
+ # concept either does not exist (Postgres) or is handled invisibly by the
+ # engine (Snowflake micro-partitions, BigQuery/Redshift internals), so the
+ # dropdown would be clutter that maps to nothing. Default `False` so an
+ # engine only advertises the feature by opting in, rather than inheriting
it
+ # and having to remember to opt out.
+ supports_partition_filter_mapping: bool = False
Review Comment:
**Suggestion:** `False` hides the mapping for engines not explicitly
updated, including partition-capable engines such as Athena, silently removing
existing functionality.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fb10bb45f073468686dca6735f0d34ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fb10bb45f073468686dca6735f0d34ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/base.py
**Line:** 734:734
**Comment:**
*Api Mismatch: `False` hides the mapping for engines not explicitly
updated, including partition-capable engines such as Athena, silently removing
existing functionality.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44431&comment_hash=b84ebe35d05fe8fbfb8f8144cdacb138d2c592a2f872328a73f0681e630480df&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44431&comment_hash=b84ebe35d05fe8fbfb8f8144cdacb138d2c592a2f872328a73f0681e630480df&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
