villebro commented on PR #44426: URL: https://github.com/apache/superset/pull/44426#issuecomment-5763075605
Quick comment: It feels confusing to have both a config flag `GLOBAL_TASK_FRAMEWORK_ENABLED` and a feature flag `GLOBAL_TASK_FRAMEWORK`, especially if the feature flag is in fact only enabling the UI bits of the feature (the name implies it's the actual feature). Also, what happens if only the feature flag is enabled, but not the config flag? @rusackas we've discussed this before, but I feel now would maybe be a good time to take a step back and decide on how and when config flags vs feature flags are used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
