Antonio-RiveroMartnez commented on PR #44426: URL: https://github.com/apache/superset/pull/44426#issuecomment-5763234335
> Quick comment: It feels confusing to have both a config flag `GLOBAL_TASK_FRAMEWORK_ENABLED` and a feature flag `GLOBAL_TASK_FRAMEWORK`, Yes, indeed, not a big fan neither, but wanted to keep it as "backward compatible" as possible (even tho it's a breaking change regardless), so, open to suggestions. > what happens if only the feature flag is enabled, but not the config flag? you'll get a `GlobalTaskFrameworkDisabledError` and a logged a warning. > decide on how and when config flags vs feature flags are used Totally, my two cents on this: `configs` should be for things that are OK to expect an app restart/re-deploy, while `Feature Flags` are for things that are expected to be dynamically available/hidden/blocked. That's why registering routes and thus permissions based on feature flags doesn't seem like a good pattern to maintain. I know this also happens for others like `SEMANTIC_LAYERS` and `ENABLE_EXTENSIONS`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
