rusackas commented on code in PR #44262:
URL: https://github.com/apache/superset/pull/44262#discussion_r4064306671
##########
superset/commands/deletion_retention/prune_audit.py:
##########
@@ -615,15 +800,17 @@ def _evidence_candidates(now: datetime, cutoff: datetime,
limit: int) -> sa.sql.
"""
table: sa.Table = PurgeAuditLog.__table__
return (
- sa.select(table.c.id)
+ sa.select(table.c.id, table.c.entity_type, table.c.entity_uuid)
Review Comment:
`_EvidenceRecheck.__call__` ignores scope entirely, so
`entity_type`/`entity_uuid` here get fetched per candidate row for nothing.
```suggestion
sa.select(table.c.id)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
