mikebridge commented on PR #44262: URL: https://github.com/apache/superset/pull/44262#issuecomment-5765672563
@aminghadersohi @rusackas the remaining review fixes are published in `1e2982ea941e126924cb0a5fc9418e4259a69b65`: - SQLite now initializes its dialect version before choosing the repeat-query path; versions below 3.25 and still-unknown versions use the legacy predicate. - Evidence discovery selects only IDs, preserving the locked recheck/delete behavior. - The isolation histories now cover both entity type and UUID. Removing the boundary UUID guard passed the prior 157-test candidate suite; the new two-chart/different-UUID regression fails under that mutation and passes when restored. The earlier cross-type fixture is preserved. Fresh local validation: 161 deletion-retention tests and all applicable full-branch-file hooks pass. Independent Astra final review approved the exact published tree, including its own SQL/mutation control. Old-SQLite/MySQL/MariaDB runtime and capacity measurements remain disclosed limits; mocked version boundaries aren't live old-engine evidence. New-head CI is running. Could you take a final pass on these fixes and re-approve if satisfied? No retention defaults or feature enablement changed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
