sadpandajoe commented on code in PR #43805:
URL: https://github.com/apache/superset/pull/43805#discussion_r4065062149
##########
superset-frontend/src/dashboard/components/menu/DownloadMenuItems/index.tsx:
##########
@@ -175,16 +313,21 @@ export const useDownloadMenuItems = (
});
// The throttle response (an export is already running) returns 202 with
a
// message but no job_id; only a freshly enqueued job carries a job_id.
- if ((json as { job_id?: string })?.job_id) {
- addSuccessToast(
- t(
- "Your export is being prepared. You'll receive an email when it's
ready.",
- ),
+ const jobId = (json as { job_id?: string })?.job_id;
+ if (jobId) {
Review Comment:
If navigation unmounts this component while the export POST is pending,
cleanup runs before this continuation, but it still emits a toast and creates
an untracked poll timer. Guest/Public exports have no email fallback, so the
completed export is then never retrieved. Could this return early when is set
before scheduling the poll?
##########
pyproject.toml:
##########
@@ -192,10 +192,17 @@ elasticsearch = ["elasticsearch-dbapi>=0.2.13, <0.3.0"]
# SQLAlchemy 2.0 core bump has landed (discussion #40273).
exasol = ["sqlalchemy-exasol>=6.0.0, <8.0"]
excel = ["xlrd>=2.0.2, <2.1"]
-# Async dashboard "Export Data/Images to Excel": uploads the workbook to S3 and
-# emails a pre-signed link. boto3 is imported lazily by superset.utils.s3, so
-# installing this extra is only required to actually run exports.
+# S3 storage backend for the async dashboard "Export Data/Images to Excel"
+# feature (EXPORT_STORAGE["backend"] = S3ExportStorage()). boto3 is
+# imported lazily by superset.utils.s3, so installing this extra is only
+# required to actually run exports.
excel-export = ["boto3"]
+# Google Cloud Storage backend for the same feature (EXPORT_STORAGE
+# ["backend"] = GCSExportStorage()), for a deployment whose export bucket is a
+# native GCS bucket rather than S3. google-cloud-storage is imported lazily by
+# superset.utils.gcs, so this extra is an alternative to excel-export, not an
+# addition to it -- pick whichever matches your bucket's provider.
+excel-export-gcs = ["google-cloud-storage"]
Review Comment:
The new GCS extra permits google-cloud-storage 1.36 and earlier, but first
appeared in 1.37; those deployments will accept the configuration and then fail
every download. Could this extra set a lower bound (or use an older-compatible
streaming API)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
