sadpandajoe commented on code in PR #43805: URL: https://github.com/apache/superset/pull/43805#discussion_r4066048033
########## UPDATING.md: ########## @@ -826,19 +826,34 @@ Note that a retried query returns partial data with no truncation indicator (e.g. a filter dropdown may list only a subset of values on tables above the row cap). -### Dashboard "Export Data to Excel" requires a Celery worker and S3 bucket +### Dashboard "Export Data to Excel" requires a Celery worker and a storage bucket Review Comment: An upgrade that already has `EXCEL_EXPORT_S3_BUCKET` (and possibly the prefix/client kwargs) configured will now have neither `EXPORT_STORAGE["bucket"]` nor a backend, so every existing Excel export starts returning 501. Could this spell out the S3-to-`EXPORT_STORAGE` migration rather than presenting it only as new configuration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
