rusackas commented on PR #44359: URL: https://github.com/apache/superset/pull/44359#issuecomment-5768203000
Pushed a fix for @EnxDev's first finding. The in-flow drop targets were collapsing because a percentage height on a flex item under GridRow's indefinite height resolves to `auto` per the flexbox spec, defeating the `align-self: stretch` this PR already declares. `height: 'auto'` fixes it, mirroring the width condition already used a few lines down for the trailing side target, and the regression test now checks both targets instead of just the first. The resize-handle z-index finding is the harder one though. `.resize-handle` isn't the actual hit-testing element, and `.dragdroppable-column`'s `translate3d` creates a stacking context the z-index can't escape. That needs real rework (dropping/reworking the transform, or portal-rendering the handles the way `ResizableContainer` already does for `CursorLabel`), not a quick patch. @EnxDev, curious your take on the right approach there before this merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
