codeant-ai-for-open-source[bot] commented on code in PR #44359:
URL: https://github.com/apache/superset/pull/44359#discussion_r4078279942
##########
superset-frontend/src/dashboard/components/resizable/ResizableContainer.tsx:
##########
@@ -130,7 +131,7 @@ const StyledResizable = styled(Resizable)`
.resize-handle {
opacity: 0;
- z-index: 10;
+ z-index: ${RESIZE_HANDLE_Z_INDEX};
Review Comment:
**Suggestion:** Column drag styles use a more specific selector with
`z-index: 10`, so this `z-index: 12` is overridden and column resize handles
still lose hit testing to hover menus.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Css layout issue`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e729998b05f34b5180c7cd006f4b7126&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e729998b05f34b5180c7cd006f4b7126&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/resizable/ResizableContainer.tsx
**Line:** 134:134
**Comment:**
*Css Layout Issue: Column drag styles use a more specific selector with
`z-index: 10`, so this `z-index: 12` is overridden and column resize handles
still lose hit testing to hover menus.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44359&comment_hash=3bb29f555f4a26d730a14e768196229db682b1e0d6431b20bdc46d03e06bf43b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44359&comment_hash=3bb29f555f4a26d730a14e768196229db682b1e0d6431b20bdc46d03e06bf43b&reaction=dislike'>๐</a>
##########
superset-frontend/src/dashboard/components/gridComponents/Row/Row.tsx:
##########
@@ -403,7 +394,7 @@ const Row = memo((props: RowProps) => {
)}
editMode
style={{
- height: rowItems.length > 0 ? containerHeight : '100%',
+ height: '100%',
Review Comment:
**Suggestion:** In an empty row, the absolute droptarget's parent has only
`height: fit-content`; its `100%` height resolves as `auto`, so the target can
collapse and lose the row's drop area.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Css layout issue`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bc520ac0a5e1401f9af5a84023b9f330&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bc520ac0a5e1401f9af5a84023b9f330&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/gridComponents/Row/Row.tsx
**Line:** 397:397
**Comment:**
*Css Layout Issue: In an empty row, the absolute droptarget's parent
has only `height: fit-content`; its `100%` height resolves as `auto`, so the
target can collapse and lose the row's drop area.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44359&comment_hash=1c484d3e2d5e3e391612835c7a80496a1346fa94e445e117e8e43eec97539031&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44359&comment_hash=1c484d3e2d5e3e391612835c7a80496a1346fa94e445e117e8e43eec97539031&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
