rusackas commented on PR #43232: URL: https://github.com/apache/superset/pull/43232#issuecomment-5768615617
Heya @MallikarjunaReddyN, this is solid groundwork for round-tripping annotation layers through export/import. One thing before this moves further though: @EnxDev's review flagged a permission gap, `overwrite=true` on chart import can mutate an existing `AnnotationLayer` without an annotation `can_write` check, plus a circular-reference case that can silently drop data on the round trip. Both still open. There's also a handful of codeant threads worth a pass, and this has conflicts with `master` plus a failing `test-mysql` job, so it'll need a rebase before we can get eyes on it again. Let us know if you want a hand with any of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
