rusackas commented on code in PR #44424:
URL: https://github.com/apache/superset/pull/44424#discussion_r4067439243
##########
tests/integration_tests/versioning/restore_fails_closed_tests.py:
##########
@@ -372,12 +373,14 @@ def
test_control_without_guard_the_partial_write_happens(self) -> None:
before: str
dataset, column, target_tx, before = self._two_version_dataset()
assert column.description != before
- parent_target_description: str =
dataset.description.removesuffix("_v2")
+ dataset_uuid: UUID = dataset.uuid
+ assert dataset_uuid is not None
+ parent_target_description: str = (dataset.description or
"").removesuffix("_v2")
Review Comment:
This one falls back to `or ""` instead of the `assert ... is not None`
pattern used everywhere else in this diff, so it'd silently produce an empty
string instead of failing loud if the fixture ever returned `None` here.
```suggestion
assert dataset.description is not None
parent_target_description: str =
dataset.description.removesuffix("_v2")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
