kokhlo commented on PR #44424: URL: https://github.com/apache/superset/pull/44424#issuecomment-5769523795
Thanks for the reviews! Since #44323 was opened 57 seconds before this one with the identical change, deferring to it and closing this PR so the two can't both merge. One note for that branch: the `or ""` fallback flagged in review at `tests/integration_tests/versioning/restore_fails_closed_tests.py:378` exists in #44323 as well — commit 4cd73af on my branch (`fix/versioning-test-mypy-uuid-narrowing`) shows the fail-loud `assert dataset.description is not None` variant, free to cherry-pick if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
