rusackas commented on PR #44201: URL: https://github.com/apache/superset/pull/44201#issuecomment-5769635923
A few of the bot findings here look real and still unaddressed: the wrong variable in the custom-rule parse call (codeant and Bito both caught it independently, so it's double counting rather than reporting custom violations), the execSync swallowing a nonzero exit before metrics get written, and the workflow only running the standard Oxlint config so custom-rule violations stop failing CI. Want to see those closed before this merges - let me know if you want a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
