hainenber commented on PR #44201: URL: https://github.com/apache/superset/pull/44201#issuecomment-5815438031
> the wrong variable in the custom-rule parse call I fixed it in https://github.com/apache/superset/pull/44201/changes/f2d02ffd514932424887df40d56509e08bb062ff > the workflow only running the standard Oxlint config so custom-rule violations stop failing CI Actually custom-rule violations do not block CI for both `master` and PRs. It's only ran in [`tech-debt` workflow](https://github.com/apache/superset/blob/master/.github/workflows/tech-debt.yml) and has `continue-on-error: true`. I should have disclosed this beforehand, as I want to ensure little to none regression to current behaviors. > the execSync swallowing a nonzero exit before metrics get written This makes sense; I'll implement this in a heartbeat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
