rusackas commented on PR #44169: URL: https://github.com/apache/superset/pull/44169#issuecomment-5769627378
Heya @Kunal8954, good progress here. The perm-cascade fix and the `datasource_type`-aware grouping in `dashboard.py` look right, and the api test's admin-session leak got sorted too. But the id-collision gap sadpandajoe flagged on `slice.py` is still open, security wise, and gabotorresruiz turned up a couple more spots with the same bare-id comparison (including the sibling filter in `dashboards/filters.py`). That needs an actual fix, not just an ack, before this merges. The purge-policy failure gabotorresruiz reproduced (14 failing tests) is also still outstanding. Rest looks close. Holler once those land (or if you want some help with any of it) and I'll take another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
