Kunal8954 commented on PR #44169: URL: https://github.com/apache/superset/pull/44169#issuecomment-5770188518
Heads up @rusackas — the PR is now merge-clean and the failing checks are addressed. - **Conflicts resolved**: re-merged the latest `master` into the branch (`dashboard.py`'s `datasets_trimmed_for_slices` now uses master's `resolved_datasource` + typed `(datasource_type, datasource_id)` grouping, keeping the id-collision keying intact; the collision test was updated to mock the resolver). `mergeStateStatus` is now `MERGEABLE`, all affected unit tests (228) pass locally, ruff + mypy clean. - **babel-extract check fixed**: the `messages.pot` drift (report-retry + screenshot strings) that was failing CI — it's also failing on plain `master`, so I regenerated via `babel_update.sh` (0 fuzzy regressions) and committed it. The items you flagged last round are still open on my list: the bare-id comparison gap on `slice.py`, the sibling filter in `dashboards/filters.py`, and the purge-policy suite. Want me to land those in this PR or a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
