bito-code-review[bot] commented on code in PR #43863: URL: https://github.com/apache/superset/pull/43863#discussion_r4068993054
########## superset-frontend/plugins/plugin-chart-echarts/src/Candlestick/index.ts: ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { t } from '@apache-superset/core/translation'; +import { Behavior } from '@superset-ui/core'; +import buildQuery from './buildQuery'; +import controlPanel from './controlPanel'; +import transformProps from './transformProps'; +import thumbnail from './images/thumbnail.png'; +import thumbnailDark from './images/thumbnail-dark.png'; +import example from './images/example1.png'; +import exampleDark from './images/example1-dark.png'; +import { + EchartsCandlestickChartProps, + EchartsCandlestickFormData, +} from './types'; +import { EchartsChartPlugin } from '../types'; + +export default class EchartsCandlestickChartPlugin extends EchartsChartPlugin< + EchartsCandlestickFormData, + EchartsCandlestickChartProps +> { + constructor() { + super({ + buildQuery, + controlPanel, + loadChart: () => import('./EchartsCandlestick'), + metadata: { + behaviors: [Behavior.DrillToDetail], Review Comment: <div> <div id="suggestion"> <div id="issue"><b>DrillToDetail declared but unhandled</b></div> <div id="fix"> Declaring `Behavior.DrillToDetail` tells the framework this plugin handles the `contextmenu` event for dimensions (`useDrillDetailMenuItems` line 145-151). But `EchartsCandlestick.tsx` only registers legend events and `transformProps.ts` never passes `onContextMenu` from `hooks`. Result: the 'Drill to detail by value' submenu is enabled but always disabled with the `NO_FILTERS` message ('Right-click on a dimension value...') even though right-clicking a dimension never produces filters. Consider implementing `contextmenu` handling or dropping the behavior. </div> </div> <small><i>Code Review Run #bcd054</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
