rusackas commented on PR #43863: URL: https://github.com/apache/superset/pull/43863#issuecomment-5801833209
Thanks for wiring up `onContextMenu` @SBIN2010. One thing before this merges: bito's point about the null case on the drill-to-detail filter seems legit... `toFilterValue` hands back `null`, so the clause becomes `== NULL` and never matches. The sibling charts (Timeseries, for one) still emit `IS NULL` there, so worth matching that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
