rusackas opened a new pull request, #44544:
URL: https://github.com/apache/superset/pull/44544
Stacked on #44543 — merge that one first, or review this one against its
diff alone once #44543 lands and this rebases down to a single line.
### SUMMARY
`required_status_checks.strict` in `.asf.yaml` is currently `false`. That
means a PR's required checks are evaluated against whatever base commit its
branch last ran CI against, not necessarily the actual `master` it's about to
land on top of. Two PRs can each individually pass, merge back to back, and
collectively break `master`, with nothing re-validating the second one against
what the first just changed.
That's exactly what happened with #44465 and #44467. #44467 added
`check_pot_drift.py` and regenerated `messages.pot`. #44465's branch predated
that merge, so its own CI never saw the new check at all, and `strict: false`
let it merge 18 minutes later anyway, silently reintroducing the drift #44467
had just fixed. #44509 cleaned that up.
#44543 (require `babel-extract`) narrows how that specific failure mode can
happen again, but doesn't close the race itself: a branch still doesn't have to
be caught up with `master` to merge. `strict: true` does — every PR has to
incorporate the latest `master` and re-run its required checks against it
before merging, so a second PR in a sequence like #44465/#44467 would be forced
to see the first one's changes and fail its own checks if the combination
breaks something.
This is **repo-wide, not translation-specific**, and it's a real tradeoff:
every merge now needs a rebase/update-branch round trip if `master` moved since
the branch last ran CI, which costs time on busy merge days. That's why this is
a separate PR from #44543 rather than bundled with it — the two are meant to be
decided independently.
### TESTING INSTRUCTIONS
`.asf.yaml` changes are synced by the ASF INFRA GitHub bot on merge to
`master`; there's no local way to simulate the resulting branch-protection
state.
```bash
python3 -c "import yaml;
print(yaml.safe_load(open('.asf.yaml'))['github']['protected_branches']['master']['required_status_checks']['strict'])"
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
