rusackas opened a new pull request, #44543:
URL: https://github.com/apache/superset/pull/44543
### SUMMARY
`babel-extract` runs `check_pot_drift.py` (added in #44467), which fails a
PR that adds or renames a translatable string without regenerating
`superset/translations/messages.pot`. It isn't in `.asf.yaml`'s required status
checks, so it can be red, or even error outright on a branch that predates the
script's own existence, without blocking merge.
That gap is what let #44465 land 18 minutes after #44467 regenerated the
template, reintroducing the exact drift #44467 had just fixed: #44465's branch
was cut before #44467 merged, so `check_pot_drift.py` didn't exist on it yet,
and nothing required `babel-extract` to be green (or present) before the merge
went through. #44509 cleaned up the resulting drift.
`babel-extract` is also the only translation-drift check gated on both
Python *and* frontend changes. `unit-tests-required` independently covers the
same script via `check_pot_drift_test.py`, but only runs when a PR touches
Python, so a frontend-only string addition (like the
`useExploreAdditionalActionsMenu` extraction bug #44467 also fixed) would slip
past `unit-tests-required` entirely. `babel-extract` is the one check that has
to be required for that case to be caught at all.
This does **not** by itself close the race that let #44465 through. That
needs `required_status_checks.strict: true` ("Require branches to be up to date
before merging"), a separate, repo-wide decision — proposing that as a
follow-up PR stacked on this one, so the two can be decided independently. This
PR only makes the existing `check_pot_drift.py` gate binding on a PR's own
branch.
### TESTING INSTRUCTIONS
`.asf.yaml` changes are synced by the ASF INFRA GitHub bot on merge to
`master`; there's no local way to simulate the resulting branch-protection
state. Validated the YAML parses and the new entry lands correctly:
```bash
python3 -c "import yaml;
print(yaml.safe_load(open('.asf.yaml'))['github']['protected_branches']['master']['required_status_checks']['contexts'])"
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
