sadpandajoe commented on code in PR #44536:
URL: https://github.com/apache/superset/pull/44536#discussion_r4076776806
##########
superset-frontend/package.json:
##########
@@ -43,7 +43,7 @@
"build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192
NODE_ENV=development webpack --mode=development --color",
"build-instrumented": "cross-env NODE_ENV=production
BABEL_ENV=instrumented webpack --mode=production --color",
"build-storybook": "storybook build",
- "build-translation": "scripts/po2json.sh",
+ "build-translation": "python3 ../scripts/translations/compile_po.py",
Review Comment:
This still fails on a standard Windows Python installation: `python3` is not
normally an executable there, so `npm run build-translation` never reaches the
cross-platform compiler. How will this script locate Python on Windows?
##########
superset-frontend/package.json:
##########
@@ -43,7 +43,7 @@
"build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192
NODE_ENV=development webpack --mode=development --color",
"build-instrumented": "cross-env NODE_ENV=production
BABEL_ENV=instrumented webpack --mode=production --color",
"build-storybook": "storybook build",
- "build-translation": "scripts/po2json.sh",
+ "build-translation": "python3 ../scripts/translations/compile_po.py",
Review Comment:
Docker builds with `BUILD_TRANSLATIONS=true` now invoke
`/app/scripts/translations/compile_po.py`, but the `superset-node` stage copies
`superset-frontend` and translations—not the root `scripts` directory—so the
build cannot find this file. Could the image stage include the compiler (and
its runtime) before this command runs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
