sadpandajoe commented on code in PR #44536: URL: https://github.com/apache/superset/pull/44536#discussion_r4076810877
########## scripts/translations/compile_po.py: ########## @@ -0,0 +1,175 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Cross-platform Python port of ``po2json.sh``. + +Compiles ``superset/translations/**/*.po`` into sibling ``.json`` files for +the frontend (``po2json``), then formats the generated JSON with ``oxfmt`` -- +the same two steps ``po2json.sh`` performed, in the same order. + +Each tool is invoked as ``node <package's own bin entry point>``, resolved +from the package's own ``package.json`` "bin" field, rather than through the +platform-specific ``node_modules/.bin`` wrapper (a symlink on POSIX, a +``.cmd``/``.ps1`` shim on Windows). ``node`` is a real executable on every +platform, so this never goes through ``cmd.exe`` the way invoking a ``.cmd`` +wrapper does (even with ``subprocess``'s ``shell=False``) -- so there is no +shell-metacharacter or ``%VAR%``-expansion surface to defend against here. + +Usage: + python scripts/translations/compile_po.py +""" + +from __future__ import annotations + +import glob +import json # noqa: TID251 - standalone script, not the Flask app +import os +import shutil +import subprocess +import sys + +ROOT_DIR = os.path.abspath( Review Comment: A later change limited to this compiler is classified as Python rather than frontend, so `superset-translations.yml` skips `npm run build-translation`; the new unit tests mock the Node calls and do not cover that integration. Could the change detector treat this compiler as frontend-relevant so the translation build remains exercised? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
