justinpark commented on PR #44276: URL: https://github.com/apache/superset/pull/44276#issuecomment-5786446071
> Heya justinpark, nice progress since sadpandajoe's pass. The CSS null-coalescing fix and the filterState-only update look like they cover those two threads, and the dashboard/explore gating landed too. > > Still a few threads open that read like real correctness gaps, not nits: the pre-normalization `form_data` mismatch on `getQuery`/`getChartData`, the missing `ownState` on paginated results, and the `GLOBAL_ASYNC_QUERIES` 202 envelope case. Also curious about the `getLayout()` type export, since the doc example doesn't actually compile as written. > > Solid foundational work on the extensions API though. Let's get those sorted before this one's merged, if we can. Holler if you want a hand with an of it. Thanks for flagging these — all four should be sorted now: - getQuery/getChartData form data mismatch: both now build their request form data from the current controls state (same as ExploreViewContainer's mapStateToProps) instead of the pre-normalization form_data slice, so they describe the same data as what's rendered. - Missing ownState on paginated results: both now pass the chart's current dataMask[chartId].ownState into the request, so a paginated/sorted table exports the page that's actually on screen instead of always page 1. - GLOBAL_ASYNC_QUERIES 202 envelope: both now route the response through the existing handleChartDataResponse before reading the result, so an uncached request under async queries is awaited instead of misread as the result. - getLayout() type export: added a LayoutNode interface and typed getLayout()'s return as Record<string, LayoutNode>, so the doc example (layout['CHART-abc123'].meta.width) actually type-checks without a cast. Pushed in 212a850 (form data/ownState/async handling) and 263624d (LayoutNode). Let me know if anything still looks off! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
