codeant-ai-for-open-source[bot] commented on code in PR #44552:
URL: https://github.com/apache/superset/pull/44552#discussion_r4078339765
##########
superset-frontend/src/explore/exploreUtils/index.ts:
##########
@@ -329,6 +333,9 @@ export const buildV1ChartDataPayload = async ({
}
});
}
+ if (clientId) {
+ payload.client_id = clientId;
+ }
Review Comment:
**Suggestion:** One `client_id` covers every query in a multi-query payload,
so later registrations overwrite earlier handles and Stop cancels only the last
warehouse query.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7588c45bfefe4011a47dca02d2c3c213&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7588c45bfefe4011a47dca02d2c3c213&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/exploreUtils/index.ts
**Line:** 336:338
**Comment:**
*Logic Error: One `client_id` covers every query in a multi-query
payload, so later registrations overwrite earlier handles and Stop cancels only
the last warehouse query.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44552&comment_hash=18ce3a0672c0a08631e6f9d7144fcb7c5db84759e535105ecbc2556d51b492ae&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44552&comment_hash=18ce3a0672c0a08631e6f9d7144fcb7c5db84759e535105ecbc2556d51b492ae&reaction=dislike'>๐</a>
##########
superset-frontend/src/components/Chart/chartAction.ts:
##########
@@ -803,7 +816,18 @@ export function exploreJSON(
const setDataMask = (dataMask: DataMask): void => {
dispatch(updateDataMask(formData.slice_id, dataMask));
};
- dispatch(chartUpdateStarted(controller, formData, key as string | number));
+ // Identifies this run to the backend so Stop can cancel the database query
+ // itself, not just abort the in-flight HTTP request. Matches SQL Lab's
+ // client id shape (see `postStopQuery`) and the `query.client_id` column.
+ const clientId = nanoid(11);
+ dispatch(
+ chartUpdateStarted(
+ controller,
+ formData,
+ key as string | number,
+ clientId,
+ ),
+ );
Review Comment:
**Suggestion:** The stop request can arrive before this chart request
registers its handle, so an immediate Stop misses and the database query
continues uncancelled.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=29f55f54c28649be9d855aeff563b260&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=29f55f54c28649be9d855aeff563b260&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/components/Chart/chartAction.ts
**Line:** 822:830
**Comment:**
*Race Condition: The stop request can arrive before this chart request
registers its handle, so an immediate Stop misses and the database query
continues uncancelled.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44552&comment_hash=1302099cf7f46e4166a8f86bbbc733047133a35c4f1f50a7e2d37710cbdc462d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44552&comment_hash=1302099cf7f46e4166a8f86bbbc733047133a35c4f1f50a7e2d37710cbdc462d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
