bito-code-review[bot] commented on PR #44552:
URL: https://github.com/apache/superset/pull/44552#issuecomment-5787644821
<!-- Bito Reply -->
The flagged issue describes a race condition where a query cancellation
request might be sent before the backend has registered the `client_id` for the
running query. To resolve this, the client should ensure the `client_id` is
generated and available before the query request is initiated, and the backend
should handle the cancellation request gracefully if the `client_id` is not yet
found.
Since the provided context does not include the specific implementation of
the `stop` action in `ExploreViewContainer/index.tsx`, I recommend verifying
that the `client_id` is passed to the backend immediately upon initiating the
query and that the frontend waits for confirmation of the query's registration
before enabling the stop button.
Would you like me to fetch all comments on this PR to validate the
correctness of other issues and implement fixes for them?
**superset-frontend/src/components/Chart/chartAction.ts**
```
export function chartUpdateStarted(
queryController: AbortController,
latestQueryFormData: QueryFormData | LatestQueryFormData,
key: string | number,
latestQueryId?: string,
): ChartUpdateStartedAction {
return {
type: CHART_UPDATE_STARTED,
queryController,
latestQueryFormData,
key,
latestQueryId,
};
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
