sha174n commented on PR #44494: URL: https://github.com/apache/superset/pull/44494#issuecomment-5795528980
Correction on my earlier CI note: the `messages.pot` drift was not a master baseline issue, the branch was just behind the commit that re-worded that string. `git diff upstream/master...HEAD -- superset/translations/` is empty, so the branch introduces no template change. Merging master in 6dc81e1ca2 clears `check_pot_drift` locally and with it all four red checks (`babel-extract` and the unit-test jobs were the same assertion). Also in 1fadf214cb: the guest test cleaned up with a bare `db.session.rollback()`, which cannot undo a commit. If the guest gate ever regressed, `run()` would commit before `pytest.raises` failed and leak the embedded row plus the overwritten query context into later tests, so both are now cleared explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
