sha174n commented on PR #44494: URL: https://github.com/apache/superset/pull/44494#issuecomment-5803026638
Cleanup tightened further in b02f3ca86a, no behavior change to the command itself: - `test_query_context_update_command` rolls back before restoring, so a mid-transaction failure in the body cannot make the restore raise `PendingRollbackError` and mask the real error. This also makes it consistent with the guest test, which already rolled back first. - `test_query_context_update_denies_guest` now puts back the embedded allowlist. `EmbeddedDashboardDAO.upsert` sets `allow_domain_list` on the row it reuses (`superset/daos/dashboard.py:752-756`), so deleting only a row this test inserted was not enough when the dashboard was already embedded. - `ExploreChartPanel` picks the logger once instead of repeating the same call in both branches. 44 targeted tests and the 18 `ExploreChartPanel` jest tests pass locally, pre-commit clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
