rusackas commented on PR #44529: URL: https://github.com/apache/superset/pull/44529#issuecomment-5802013379
Thanks @hadimobarra, the follow-up looks right to me: the lazy import, `preserveDrawingBuffer` only on WebKit, and keeping the ag-grid print layout on the Safari path. One thing worth a look before this merges: codeant's thread on the capture dimensions seems accurate, since the Safari branch sizes the canvas from `elementToPrint` before `processCloneForVisibility` expands anything, while the other path measures the clone afterward. Mind assessing/resolving that one and the CORS one? @rebenitez1802 the WebGL question was yours, so I'll leave the re-review call to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
