bito-code-review[bot] commented on code in PR #44529:
URL: https://github.com/apache/superset/pull/44529#discussion_r4086973864
##########
superset-frontend/src/utils/downloadAsImage.tsx:
##########
@@ -18,10 +18,12 @@
*/
import { SyntheticEvent } from 'react';
import domToImage from 'dom-to-image-more';
+import html2canvas from 'html2canvas';
Review Comment:
<!-- Bito Reply -->
The observation is correct. By moving the `html2canvas` import inside the
`isSafari()` branch, the library is only loaded when necessary, preventing it
from bloating the core bundle. This aligns with the existing lazy-loading
pattern used for other heavy dependencies in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
