drivaspreset commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r4086793716
##########
superset-frontend/playwright.config.ts:
##########
@@ -161,6 +168,25 @@ export default defineConfig({
},
]
: []),
+ // Global Async Queries tests need the GLOBAL_ASYNC_QUERIES feature flag
+ // enabled in the Flask backend, plus Redis and a running Celery worker --
+ // without a worker, submissions return 202 and no job ever executes. The
+ // workflow's GAQ step provisions all three and sets INCLUDE_GAQ, so these
+ // specs never load in the required run, where the pipeline is inert. Same
+ // strict 'true' check as INCLUDE_EMBEDDED.
+ ...(process.env.INCLUDE_GAQ?.toLowerCase() === 'true'
+ ? [
+ {
+ name: 'chromium-gaq',
Review Comment:
Fixed in c4d3523adb.
One addition: `fullyParallel: false` alone only orders tests within a single
file — Playwright still runs separate files concurrently, and this suite
spans
three. So the project sets `fullyParallel: false` *and* `playwright-run-gaq`
pins `--workers=1`, which is what actually serializes it. Both are commented
with why so they don't get cleaned up later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
