EnxDev commented on code in PR #43938: URL: https://github.com/apache/superset/pull/43938#discussion_r4087582459
########## superset/translations/messages.pot: ########## @@ -157,6 +157,62 @@ msgstr "" msgid "!= (Is not equal)" msgstr "" +msgid "Add group" Review Comment: These 18 entries were added by hand after `!= (Is not equal)`, but `babel_update.sh` sorts by msgid (`--sort-output` and `msgcat --sort-by-msgid`), so `Add group` should land next to `Add filter` around line 1345. The drift check only compares sets of strings, so CI will pass. The next person who runs the script, though, gets these moved in the pot and in all 30 catalogs as unrelated noise in their PR. Could you run `./scripts/translations/babel_update.sh` and commit what it produces? The Italian `msgstr`s should carry over, since `pybabel update` keeps existing translations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
