SBIN2010 commented on PR #43938: URL: https://github.com/apache/superset/pull/43938#issuecomment-5809829615
> Fourth pass on [7a3fdd0](https://github.com/apache/superset/commit/7a3fdd0d88b872b233ab7090bf9e765cf53e7cd0) through [01b5a29](https://github.com/apache/superset/commit/01b5a29338d740cecd89a42f58596738ddf3dc2f), replacing [the previous one](https://github.com/apache/superset/pull/43938#pullrequestreview-5297109927). > > No code has changed since my last pass, only the translation files, and CI is green now, including the jest shard and babel-extract. The catalogs are in good shape: the pot has exactly the 18 new msgids on top of master, they're in sorted position (`Add group` sits right after `Add filter`), and the 25 do-not-translate markers are still there. From my side this is good to go. > > Two FYIs, neither blocking: > > The Italian `msgstr`s from [6ca0a77](https://github.com/apache/superset/commit/6ca0a7761167a69f0d2bdb026cebaf6159f8b4a8) didn't survive the regen, so `Add group`, `Table side` and the rest are empty in `it/messages.po` again. I told you last time they'd carry over, and that was wrong. If you want them back, filling them in place at the sorted positions is fine now. > > About 2.5k lines of the pot diff are just rewrapping. `babel_update.sh` runs `msgcat --no-wrap`, but master's pot is wrapped at 76 columns, probably because recent regens ran without `msgcat` installed and fell back to babel's default width. So you got the output the script intends, and master is the one that's drifted. The catch is that any other PR touching the pot will conflict with this one. The script and master need to agree on one format, but that's a separate fix, so I won't hold this PR on it. added translations, new lines in all locales -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
