bazhil opened a new pull request, #44664: URL: https://github.com/apache/superset/pull/44664
### SUMMARY Table chart XLSX download did not include Explore adaptive formatting. The export writes the workbook in `QueryContextProcessor.get_data` before client post-processing, so `conditional_formatting` never reached the file. For Table charts, the export now writes native Excel conditional formatting: comparator rules as CellIs (fill or font), operator `None` as a color scale, range operators as formulas, and **cell bar** as Excel data bars. If there are no custom rules and `show_cell_bars` is on, numeric columns get data bars like the default Table gradient. Sheet bounds are refreshed so rules cover all data rows, not only the header. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before.** Explore Table shows cell bars / color formatters; the XLSX has values only. <img width="1629" height="950" alt="изображение" src="https://github.com/user-attachments/assets/4d9cdd2a-74ef-4c46-a524-c71e02337367"; /> <img width="1629" height="950" alt="изображение" src="https://github.com/user-attachments/assets/92a14b8a-2db0-4165-9f4e-8a05d7f3411c"; /> **After.** Matching columns in the XLSX have Excel data bars or CellIs/color-scale rules. Screenshots: `screenshots/after/`. <img width="1660" height="939" alt="Снимок экрана от 2026-09-25 22-01-09" src="https://github.com/user-attachments/assets/90ffb814-3a7f-4c0d-bc69-e96e00c617e1"; /> <img width="1660" height="939" alt="Снимок экрана от 2026-09-25 22-01-49" src="https://github.com/user-attachments/assets/d61251ca-4b2c-42e9-9c5c-25e4d2b67bad"; /> <img width="1660" height="939" alt="Снимок экрана от 2026-09-25 22-02-54" src="https://github.com/user-attachments/assets/77846928-c9ac-453e-a7e5-b0852b70e4a9"; /> <img width="1670" height="967" alt="Снимок экрана от 2026-09-25 22-05-44" src="https://github.com/user-attachments/assets/8b97cfa9-7572-4d6b-9b08-0ecdc6bab9c6"; /> ### TESTING INSTRUCTIONS ```bash pytest tests/unit_tests/utils/test_excel_conditional.py -q pytest tests/unit_tests/charts/test_client_processing.py::test_apply_client_processing_xlsx_attaches_table_cell_bars -q ``` Manual: 1. Table chart, Raw records, `show_cell_bars` on, no custom formatters. Download XLSX: numeric columns have data bars. 2. Add a rule `sales > 10` with background color. Download: Excel CellIs greater-than on `sales`. 3. Add a rule with Formatting object **cell bar** on a numeric column. Download: Excel data bar on that column. 4. Confirm text columns (e.g. `region`) do not get data bars from `show_cell_bars`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
