aminghadersohi opened a new pull request, #44856: URL: https://github.com/apache/superset/pull/44856
### SUMMARY The cross-referenced dashboards test types into the Save modal before existing dashboards load. That can select the create-new option and leave behind an empty duplicate that cleanup does not track. The mobile chart-loading test then fails when that duplicate is the first dashboard card. Wait for the dashboard list response, verify it contains the intended existing dashboard, and select an exact title match before saving. Keep this behavior local to the overwrite test. Use the World Bank's Health sample dashboard for mobile interaction tests instead of relying on list order. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; test-only changes. ### TESTING INSTRUCTIONS With the example dashboards loaded and `MOBILE_CONSUMPTION_MODE` enabled, run: ```bash cd superset-frontend npx playwright test playwright/tests/explore/cross-referenced-dashboards.spec.ts playwright/tests/mobile/mobile-dashboard.spec.ts ``` Confirm the chart is added to the existing dashboards without creating duplicates, and mobile charts load even when an empty dashboard sorts first. Repeat with the dashboard-list response delayed. Local validation: formatting, oxlint, custom rules, stylelint, and whitespace checks passed via staged-file pre-commit. The type-check hook is blocked by missing Jest types; a targeted `npx tsc` attempt is blocked by missing frontend workspace dependencies. Playwright was not run because no app is listening on port 8088. No environment was started. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
