bito-code-review[bot] commented on code in PR #44856:
URL: https://github.com/apache/superset/pull/44856#discussion_r4151817864
##########
superset-frontend/playwright/tests/mobile/mobile-dashboard.spec.ts:
##########
@@ -35,25 +35,10 @@ import { URL } from '../../utils/urls';
// Use iPhone 12 viewport for mobile tests
const mobileViewport = devices['iPhone 12'];
-/**
- * Navigates to the dashboard list, clicks the first available dashboard
- * card, and waits for navigation into that dashboard. Skips the current
- * test when no dashboards are available to open.
- */
-async function openFirstDashboard(page: Page): Promise<void> {
- await page.goto(URL.DASHBOARD_LIST);
+/** Opens the sample dashboard with charts, independently of dashboard list
order. */
+async function openExampleDashboard(page: Page): Promise<void> {
+ await page.goto('dashboard/world_health/');
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing existence guard</b></div>
<div id="fix">
The removed `openFirstDashboard` skipped when no dashboards were available;
`openExampleDashboard` now navigates straight to `dashboard/world_health/` with
no existence check. The suite's `beforeAll` skip only counts cards on the
dashboard list, so it won't catch a missing `world_health` dashboard — the test
then fails on a 404 instead of skipping. Add a `world_health`-specific skip
guard.
</div>
</div>
<small><i>Code Review Run #bf9709</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
