sadpandajoe commented on code in PR #44554:
URL: https://github.com/apache/superset/pull/44554#discussion_r4151818621
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.test.tsx:
##########
@@ -246,3 +246,48 @@ describe('BigNumberViz trendline context menu', () => {
expect(onContextMenu).not.toHaveBeenCalled();
});
});
+
+describe('BigNumberViz alignment', () => {
+ const renderViz = (headerAlignment?: HeaderAlignment) =>
+ render(
+ <BigNumberVis
+ width={200}
+ height={100}
+ bigNumber={42}
+ headerFormatter={getNumberFormatter()}
+ headerFontSize={0.3}
+ subheaderFontSize={0.125}
+ subtitleFontSize={0.125}
+ subtitle=""
+ refs={{}}
+ headerAlignment={headerAlignment}
Review Comment:
These cases render only the number and never enter the trendline overflow
layout, so they would still pass if the subheader stopped honoring Center.
Could we add a trendline case with a subheader, force text-height overflow, and
assert that both the value and subheader stay centered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
