rusackas commented on code in PR #44554:
URL: https://github.com/apache/superset/pull/44554#discussion_r4152955172
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.test.tsx:
##########
@@ -246,3 +246,48 @@ describe('BigNumberViz trendline context menu', () => {
expect(onContextMenu).not.toHaveBeenCalled();
});
});
+
+describe('BigNumberViz alignment', () => {
+ const renderViz = (headerAlignment?: HeaderAlignment) =>
+ render(
+ <BigNumberVis
+ width={200}
+ height={100}
+ bigNumber={42}
+ headerFormatter={getNumberFormatter()}
+ headerFontSize={0.3}
+ subheaderFontSize={0.125}
+ subtitleFontSize={0.125}
+ subtitle=""
+ refs={{}}
+ headerAlignment={headerAlignment}
Review Comment:
Added a case forcing the trendline overflow layout with a subheader,
asserting both stay centered. Since `header-line` and `subheader-line` set
their own `justifyContent`/`textAlign`, they hold regardless of the parent's
`display: block`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
