codeant-ai-for-open-source[bot] commented on code in PR #44849:
URL: https://github.com/apache/superset/pull/44849#discussion_r4158414979
##########
superset/semantic_layers/models.py:
##########
@@ -257,9 +259,18 @@ def after_delete(
security_manager.semantic_layer_after_delete(mapper, connection,
target)
- @cached_property
+ @property
def implementation(
self,
+ ) -> SemanticLayerABC[Any, SemanticViewABC]:
+ if metadata_binding.participates(self):
+ # Read authorization belongs to callers with full request context.
+ return metadata_binding.layer_implementation(self)
+ return self._legacy_implementation
+
+ @cached_property
+ def _legacy_implementation(
+ self,
) -> SemanticLayerABC[Any, SemanticViewABC]:
Review Comment:
**Suggestion:** When a layer's configuration changes on an existing ORM
object, this cached provider remains tied to the old configuration and
subsequent queries use stale metadata.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3678d3a738494c8882d113848072f19d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3678d3a738494c8882d113848072f19d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/models.py
**Line:** 271:274
**Comment:**
*Stale Reference: When a layer's configuration changes on an existing
ORM object, this cached provider remains tied to the old configuration and
subsequent queries use stale metadata.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44849&comment_hash=e5eb8bb78b8aab47743271ededdd2c15fa5bf5c1ba23cb872f9a13fc2c438b7f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44849&comment_hash=e5eb8bb78b8aab47743271ededdd2c15fa5bf5c1ba23cb872f9a13fc2c438b7f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
