mikebridge commented on PR #44396: URL: https://github.com/apache/superset/pull/44396#issuecomment-5942859105
@rusackas thanks for catching the `export_as_example` gap. I reproduced it on the reviewed head: a native filter targeting a semantic view picked up an unrelated table's UUID when their numeric ids matched. (The chart's own `datasource` property is table-only there, so the wrong substitution happens in the filter remapping.) Went with the guard here rather than a follow-up: `f03dc1eb` makes `ExportExampleCommand` reject dashboards whose charts or native-filter targets use semantic views, before any example content is built, and the route returns a 422. Red-first tests cover the collision, standalone filter targets and a chart whose view row is gone; an ordinary table-only dashboard exports byte-for-byte as before. 482 affected tests pass (2 expected xfails). One wording nit of our own is still to come: the UPDATING.md line and the route's OpenAPI text read as if every native-filter target were rejected, when it's only semantic-view targets. I'll tidy that with the master merge that clears the CodeQL check. On gabotorresruiz's `chart/export.py` thread about an orphaned semantic-view chart blocking a whole export: that was addressed in `f4d029a33a` (the view-existence check at `chart/export.py:78-80`, with a mixed orphan regression test), and I replied there on Sep 30. The thread is still open on his side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
